Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local IP/CIDR to Security Group and SG Rule #301

Closed
wants to merge 9 commits into from

Conversation

SunithaGudisagarIBM1
Copy link
Collaborator

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 commented Oct 26, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISSecurityGroupRule_basic'
...
Screenshot 2024-01-29 at 10 44 08 AM
resource "ibm_is_security_group_rule" "testacc_security_group_rule_tcp_any" {
  group     = "r134-a2f82965-1b8d-4bfe-9949-fe79e47daa86"
  local     = "192.168.3.4"
  direction = "inbound"
  remote    = "127.0.0.1"
  tcp {
  }
}

data "ibm_is_security_group_rule" "example" {
  security_group_rule = "r134-cbee5b37-3fa3-4c33-beff-608a1855efe0"
  security_group      = "r134-a2f82965-1b8d-4bfe-9949-fe79e47daa86"
}

data "ibm_is_security_group_rules" "examples" {
  security_group      = "r134-a2f82965-1b8d-4bfe-9949-fe79e47daa86"
}

data "ibm_is_security_group" "sg1_rule" {
  name = "concrete-proudly-coastal-obvious"
}

data "ibm_is_security_groups" "example" {
}

Screenshot 2024-01-27 at 5 34 15 PM Screenshot 2024-01-29 at 8 38 40 AM Screenshot 2024-01-29 at 8 46 02 AM Screenshot 2024-01-29 at 10 17 15 AM Screenshot 2024-01-29 at 10 26 01 AM

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 changed the title Feature is sg rule local ip Local IP/CIDR to Security Group and SG Rule Oct 26, 2023
Copy link
Collaborator

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@SunithaGudisagarIBM1 SunithaGudisagarIBM1 force-pushed the feature-is-sg-rule-local-ip branch from 376aa4f to c1005ac Compare March 4, 2024 08:38
@SunithaGudisagarIBM1
Copy link
Collaborator Author

make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISSecurityGroupRule_basic'

Incorporated and tested as well

@SunithaGudisagarIBM1
Copy link
Collaborator Author

moving upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants